Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation: Lift log limits option in SimulateRequest #469

Merged
merged 23 commits into from
Apr 28, 2023
Merged

Simulation: Lift log limits option in SimulateRequest #469

merged 23 commits into from
Apr 28, 2023
+113 −42

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Apr 24, 2023

No description provided.

@ahangsu ahangsu marked this pull request as ready for review April 25, 2023 17:58
@ahangsu ahangsu requested a review from jasonpaulos April 25, 2023 17:58
ahangsu
ahangsu commented Apr 26, 2023
View reviewed changes
.test-env Outdated Show resolved Hide resolved
jasonpaulos
jasonpaulos reviewed Apr 26, 2023
View reviewed changes
algosdk/atomic_transaction_composer.py Outdated Show resolved Hide resolved
algosdk/atomic_transaction_composer.py Outdated Show resolved Hide resolved
tests/steps/other_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/other_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/other_v2_steps.py Outdated Show resolved Hide resolved
algosdk/atomic_transaction_composer.py Outdated Show resolved Hide resolved
@ahangsu ahangsu force-pushed the lift-log-limits branch 2 times, most recently from 2faf8be to 63dcbec Compare April 27, 2023 17:15
@ahangsu ahangsu requested a review from jasonpaulos April 27, 2023 19:11
jasonpaulos
jasonpaulos reviewed Apr 27, 2023
View reviewed changes
algosdk/atomic_transaction_composer.py Show resolved Hide resolved
algosdk/atomic_transaction_composer.py Outdated Show resolved Hide resolved
tests/steps/other_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/other_v2_steps.py Outdated Show resolved Hide resolved
jasonpaulos
jasonpaulos approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you revert .test-env, looks good to me!

@ahangsu ahangsu merged commit 7946b17 into develop Apr 28, 2023
@ahangsu ahangsu deleted the lift-log-limits branch April 28, 2023 17:17
@algobarb algobarb mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbroder-algo bbroder-algo bbroder-algo left review comments

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahangsu @jasonpaulos @bbroder-algo